cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-android pull request: CB-8484: Adds support creating signe...
Date Thu, 26 Mar 2015 21:45:57 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
     module.exports.runClean = function(options) {
         var opts = parseOpts(options);
         var builder = builders[opts.buildMethod];
    -    return builder.prepEnv()
    +    return builder.prepEnv(opts)
         .then(function() {
    -        return builder.clean(opts.extraArgs);
    +        return builder.clean(opts);
         }).then(function() {
             shell.rm('-rf', path.join(ROOT, 'out'));
    +    }).then(function() {
    +        ['debug', 'release'].forEach(function(config) {
    +            removeIfExists(path.join(ROOT, config + SIGNING_PROPERTIES));
    --- End diff --
    Good point. To delete these files the user has to explicitly run the `clean` script  from
platforms\android\cordova. This made me think about other scenarios as well for CLI workflow:
    1. cordova build <nopackageInfo>
    2. cordova build <packageInfo>
    3. cordova build <nopackageInfo>
    The third invocation will use the pacakgeInfo from the previous invocation as I do not
delete & release-signing.properies.
    I can make this a bit more sophisticated to account for non-CLI workflows - detect if
the file is auto-generated (It has the canned comment ("Do not modify this file -- YOUR CHANGES
WILL BE ERASED")). If it is then I go ahead and delete it not only on `clean` but also when
starting a build with no package info specified.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message