cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deadbird1980 <...@git.apache.org>
Subject [GitHub] cordova-plugin-network-information pull request: CB-8185 Use `navi...
Date Thu, 26 Mar 2015 15:15:26 GMT
Github user deadbird1980 commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-network-information/pull/25#discussion_r27221938
  
    --- Diff: www/network.js ---
    @@ -26,7 +26,9 @@ var exec = require('cordova/exec'),
     // Link the onLine property with the Cordova-supplied network info.
     // This works because we clobber the navigator object with our own
     // object in bootstrap.js.
    -if (typeof navigator != 'undefined') {
    +// Browser platform do not need to define this property, because
    +// it is already supported by modern browsers
    +if (cordova.platforId !== 'browser' && typeof navigator != 'undefined') {
    --- End diff --
    
    I think it should be cordova.platformId here, just found this problem when testing latest
code on browser.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message