cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-8753 Maintain splash screen aspec...
Date Thu, 26 Mar 2015 13:54:43 GMT
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-android/pull/168#issuecomment-86521912
  
    Great questions.
    
    The statics are meant to prevent multiple splash screens from showing if there is more
than one CordovaWebView within a project.
    
    `CordovaPreferences.copyIntoIntentExtras(Activity)` - it's legacy.
    
    keep getting preferences from CordovaPreferences - because embedders can change these
preferences during app start-up, and we want those changes to take effect.
    
    New Prefs android only - yes. that's fine. Splash screen already has mostly platform-specific
prefs :(
    
    Overall comments:
    - Randomly, an `onConfigurationChange` hook was just recently added to master, so you
should just use that instead.
    - We aren't planning on doing another release of 3.x branch, so you should make these
changes to cordova-plugin-splashscreen, which is what will work with cordova-android@4.0.x
(and with master branch of cordova-android)
    - I don't see why anyone would want reloadOnOrientationChange=false, so maybe don't make
that a preference?
    - Might be better to get rid of the LinearLayout, and instead switch to an ImageView in
both cases


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message