cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...
Date Fri, 13 Mar 2015 07:07:08 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-windows/pull/61#issuecomment-78841786
  
    Hi Ray,
    
    I have created an issue in JIRA for this, thanks for bringing it to my attention.
    I have merged your pull request into my own. here: #62 
    Please have a look and review it.
    I removed some of the strict checking as != null will return true for both undefined and
null, but not 0
    
    Here's the long form proof ... I also considered using hasOwnProperty
    
    ```
    // Loose equality
    ({status:undefined}).status != null // false
    ({status:undefined}).status != undefined // false
    ({status:undefined}).status != 0 // true
    
    ({status:null}).status != undefined // false
    ({status:null}).status != null // false
    ({status:null}).status != 0 // true
    
    ({status:0}).status != null // true
    ({status:0}).status != undefined // true
    ({status:0}).status != 0 // false
    
    // Strict equality
    ({status:undefined}).status !== null // true
    ({status:undefined}).status !== undefined // false
    ({status:undefined}).status !== 0 // true
    
    ({status:null}).status !== null // false
    ({status:null}).status !== undefined // true
    ({status:null}).status !== 0 // true
    
    ({status:0}).status !== null // true
    ({status:0}).status !== undefined // true
    ({status:0}).status !== 0 // false
    
    ({status:undefined}).hasOwnProperty('status') // true
    ({status:null}).hasOwnProperty('status') // true
    ({status:0}).hasOwnProperty('status') // true
    ({}).hasOwnProperty('status') // false
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message