cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dmitriy-barkalov <>
Subject [GitHub] cordova-medic pull request: Medic Refactor
Date Thu, 12 Mar 2015 10:07:21 GMT
Github user dmitriy-barkalov commented on a diff in the pull request:
    --- Diff: buildbot-conf/cordova-internal.conf ---
    @@ -0,0 +1,101 @@
    +import os
    +import json
    +from buildbot.changes.gitpoller import GitPoller
    +from buildbot.schedulers.forcesched import ForceScheduler
    +# config
    +MEDIC_CONFIG_FILE    = os.path.join(FP, 'cordova-config.json')
    +PROJECTS_CONFIG_FILE = os.path.join(FP, 'cordova-repos.json')
    +def parse_config_file(file_name):
    +    with open(file_name, 'r') as config_file:
    +        return json.load(config_file)
    +medic_config    = parse_config_file(MEDIC_CONFIG_FILE)
    +projects_config = parse_config_file(PROJECTS_CONFIG_FILE)
    +# constants
    +GIT_BIN       = 'git' if != 'nt' else 'C:\Program Files (x86)\Git\cmd\git.exe'
    +GITPOLLER_DIR = 'gitpoller-workdir'
    +    'cordova-mobile-spec',
    +    'cordova-lib',
    +    'cordova-js',
    +    'cordova-cli',
    +    'cordova-medic',
    +    'cordova-plugman',
    +    'cordova-windows',
    +    'cordova-android',
    +####### UTILITIES
    +# helpers
    +def cordova_builders():
    +    return [ for b in c['builders'] if'cordova-')]
    +def is_polled_project(project_name):
    +    return True if any(pattern in project_name for pattern in POLLED_PROJECT_PATTERNS)
else False
    +def get_polled_projects():
    +    return (project for project_name, project in projects_config.items() if is_polled_project(project_name))
    +def make_git_poller(repo_uri):
    +    # NOTE:
    +    #      branches=True means watching all branches
    +    return GitPoller(repo_uri, workdir=GITPOLLER_DIR, branches=True, pollinterval=120,
    --- End diff --
    As far as schedulers is not configured what is the purpose of this gitpoller config exists?
Lets remove it and add this functionality in other PR together with schedulers.
    I think it is confusing now. Also gitpoller clones all the repositories and store local
copies on master. So HDD and CPU of master will be used for no reason.
    Also I was under impression that gitpoller also need to be setup more specific using `project`
and `category` parameters to make schedulers able to filter gitpoller requests.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message