cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CJRChang <>
Subject [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...
Date Thu, 12 Mar 2015 07:03:09 GMT
Github user CJRChang commented on a diff in the pull request:
    --- Diff: cordova-js-src/exec.js ---
    @@ -60,18 +60,32 @@ module.exports = function (success, fail, service, action, args) {
                 // CB-5806 [Windows8] Add keepCallback support to proxy
                 onSuccess = function (result, callbackOptions) {
                     callbackOptions = callbackOptions || {};
    +                var callbackStatus;
    +                if (callbackOptions.status !== null) {
    --- End diff --
    My sincere apologies sir - you're quite right and I've amended the code to handle undefined.
    I've evidently been writing too much code in too many languages at once.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message