cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...
Date Thu, 12 Mar 2015 06:27:28 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/61#discussion_r26281092
  
    --- Diff: cordova-js-src/exec.js ---
    @@ -60,18 +60,32 @@ module.exports = function (success, fail, service, action, args) {
                 // CB-5806 [Windows8] Add keepCallback support to proxy
                 onSuccess = function (result, callbackOptions) {
                     callbackOptions = callbackOptions || {};
    +                var callbackStatus;
    +                if (callbackOptions.status !== null) {
    --- End diff --
    
    If the user passed undefined explicitly, it would have evaluated to falsy and in line
65 (pre-change) would have been replaced with cordova.callbackStatus.OK.  With your change,
line 64's (post-change) test is true (undefined !== null), so local callbackStatus becomes
undefined (line 65), and the status property is undefined (line 72 or 88).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message