cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmocny <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8595 Merge platforms.js from cordova ...
Date Wed, 11 Mar 2015 14:03:30 GMT
Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/183#discussion_r26213790
  
    --- Diff: cordova-lib/src/PluginInfo.js ---
    @@ -288,6 +293,19 @@ function PluginInfo(dirname) {
                 return ret;
             });
         };
    +
    +    self.getFilesAndFrameworks = getFilesAndFrameworks;
    +    function getFilesAndFrameworks(platform) {
    +        var items = [];
    +        // Please avoid changing the order of the calls below, files will be
    +        // installed in this order.
    +        items = items.concat(self.getSourceFiles(platform));
    +        items = items.concat(self.getHeaderFiles(platform));
    +        items = items.concat(self.getResourceFiles(platform));
    +        items = items.concat(self.getFrameworks(platform));
    +        items = items.concat(self.getLibFiles(platform));
    --- End diff --
    
    Tip: `concat` actually accepts any number of arguments and will concat all in one go.
    
    Can also do: `[].concat.apply([], [ self.getSourceFiles(..), self.getHeaderFiles(..),
...])`
    
    Which I think looks nicest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message