cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: Medic Refactor
Date Tue, 10 Mar 2015 19:31:36 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/37#discussion_r26157156
  
    --- Diff: buildbot-conf/master.cfg ---
    @@ -17,37 +17,75 @@
     # Absolute or relative path to buildbot per-project configureations.
     # For local Buildbot installation it is convenient to use the same directory
     # for main master.cfg and projects .conf files
    -FP = "./"
    +FP = './'
     
     c = BuildmasterConfig = {}
     
     ####### BUILDSLAVES
     
    -# import the passwds
    -
    -# import private
    -# reload(private)
    +# import the passwords
    +import private
    +reload(private)
     
     # c['db_url'] = private.mysqlConnection
     
    +c['db'] = {
    +    'db_url' : "sqlite:///state.sqlite",
    +}
    +
     # the 'slaves' list defines the set of allowable buildslaves. Each element is
     # a tuple of bot-name and bot-password. These correspond to values given to
     # the buildslave's mktap invocation.
     from buildbot.buildslave import BuildSlave
     
    -c['slaves'] = [
    -    BuildSlave("cordova-ios-slave", "pass", max_builds=1),
    -    BuildSlave("cordova-android-slave", "pass", max_builds=1),
    -    BuildSlave("cordova-windows-slave", "pass", max_builds=1),
    -    BuildSlave("cordova-win8-slave", "pass", max_builds=1),
    -    BuildSlave("cordova-blackberry-slave", "pass", max_builds=1),
    -    BuildSlave("cordova-common-slave", "pass", max_builds=3),
    -]
    +c['slaves'] = []
    +
    +c['slaves'].extend([
    +
    +    # used slaves
    +    BuildSlave(
    +        'cordova-ios-slave',
    +        private.slave34Pwd,
    --- End diff --
    
    Yes, it seems like we will just need to keep our `master.cfg` defining the same slaves
as Apache's `master.cfg`, and not move them to `cordova.conf`. I changed the password constants
to be more descriptive, since now they don't need to be moved to `cordova.conf` and don't
need to match Apache's `master.cfg`. Only slave names will need to stay the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message