cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <>
Subject [GitHub] cordova-plugin-splashscreen pull request: [WP8] Respect SplashScre...
Date Tue, 10 Mar 2015 18:21:08 GMT
Github user robpaveza commented on a diff in the pull request:
    --- Diff: src/wp/SplashScreen.cs ---
    @@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
         /// </summary>
         public class SplashScreen : BaseCommand
    +        private readonly Preferences preferences = new Preferences();
             private Popup popup;
    -        private bool autohide = true;
             private static bool WasShown = false;
    --- End diff --
    Nits: Why static?  Why PascalCased for a private?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message