cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: [WP8] Respect SplashScre...
Date Tue, 10 Mar 2015 18:17:28 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26149711
  
    --- Diff: src/wp/SplashScreen.cs ---
    @@ -163,5 +190,30 @@ public void hide(string options = null)
                     story.Begin();
                 });
             }
    +
    +        private void StartAutoHideTimer()
    +        {
    +            var timer = new DispatcherTimer() { Interval = TimeSpan.FromMilliseconds(preferences.SplashScreenDelay)
};
    +            timer.Tick += (object sender, EventArgs e) =>
    --- End diff --
    
    Suggest: Promote the Tick handler to a member function.  In the callback, remove the Tick
handler.  This eliminates the circular reference which is created by auto-referencing 'this'
in your callback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message