cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: [WP8] Respect SplashScre...
Date Tue, 10 Mar 2015 17:25:23 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26143768
  
    --- Diff: src/wp/SplashScreen.cs ---
    @@ -68,27 +77,52 @@ public override void OnInit()
                 if (!WasShown)
                 {
                     WasShown = true;
    -                show();
    +                this.show();
                 }
             }
     
    -        void LoadConfigValues()
    +        private static void GetPreference(XDocument document, string preferenceName,
Action<string> action)
    --- End diff --
    
    This method works somewhat backwards, where you check up to N strings for every preference,
making your worst-case performance O(n^2) (in the case that you don't find the preferences).
 Suggested alternative: Populate a Dictionary<string, Action<string>>, and then
for-each preference element, if (dictionary.TryGetValue(preferenceName, out action)) action(value).
 Dictionary lookups approach O(1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message