cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...
Date Tue, 10 Mar 2015 05:31:42 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/182#discussion_r26099723
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -290,16 +290,16 @@ function remove(hooksRunner, projectRoot, targets, opts) {
         }).then(function() {
             var config_json = config.read(projectRoot);
             var autosave =  config_json.auto_save_platforms || false;
    -	if(opts.save || autosave){
    -	    targets.forEach(function(target) {
    -		var platformName = target.split('@')[0];
    -		var xml = cordova_util.projectConfig(projectRoot);
    -		var cfg = new ConfigParser(xml);
    -		events.emit('log', 'Removing ' + target + ' from config.xml file ...');
    -		cfg.removeEngine(platformName);
    -		cfg.write();
    -	    });
    -	}
    +    if(opts.save || autosave){
    --- End diff --
    
    Please, revert these changes. no-op.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message