cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Deprecate the old feature syntax from co...
Date Tue, 10 Mar 2015 05:17:21 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/182#discussion_r26099327
  
    --- Diff: cordova-lib/spec-cordova/test-config.xml ---
    @@ -1,53 +1,34 @@
    -<?xml version="1.0" encoding="UTF-8"?>
    -<widget xmlns     = "http://www.w3.org/ns/widgets"
    -        xmlns:cdv = "http://cordova.apache.org/ns/1.0"
    -        id        = "io.cordova.hellocordova"
    -        version   = "0.0.1"
    -        android-packageName="io.cordova.hellocordova.android"
    -        ios-CFBundleIdentifier="io.cordova.hellocordova.ios">
    +<?xml version='1.0' encoding='utf-8'?>
    +<widget android-packageName="io.cordova.hellocordova.android" id="io.cordova.hellocordova"
ios-CFBundleIdentifier="io.cordova.hellocordova.ios" version="0.0.1" xmlns="http://www.w3.org/ns/widgets"
xmlns:cdv="http://cordova.apache.org/ns/1.0">
         <name>Hello Cordova</name>
    -
         <description>
             A sample Apache Cordova application that responds to the deviceready event.
         </description>
    -
    -    <author href="http://cordova.io" email="dev@cordova.apache.org">
    +    <author email="dev@cordova.apache.org" href="http://cordova.io">
             Apache Cordova Team
         </author>
    -
         <content src="index.html" />
    -
         <access origin="*" />
         <preference name="fullscreen" value="true" />
         <preference name="webviewbounce" value="true" />
         <preference name="orientation" value="portrait" />
         <icon id="icon" src="icon.png" />
    -    <icon id="logo" src="logo.png" width="255" height="255" />
    +    <icon height="255" id="logo" src="logo.png" width="255" />
         <platform name="android">
    -        <icon src="logo-android.png" width="255" height="255" density="mdpi" />
    +        <icon density="mdpi" height="255" src="logo-android.png" width="255" />
             <preference name="android-minSdkVersion" value="10" />
             <preference name="orientation" value="landscape" />
         </platform>
    -
    -    <!-- Features -->
    -    <feature name="A feature with preference">
    -        <param name="id" value="org.apache.cordova.featurewithvars"/>
    -        <param name="var" value="varvalue"/>
    -    </feature>
    -    <feature name="A feature with url">
    -        <param name="id" value="org.apache.cordova.featurewithurl" />
    -        <param name="url" value="http://cordova.apache.org/featurewithurl" />
    -    </feature>
    -    <feature name="A feature with version">
    -        <param name="id" value="org.apache.cordova.featurewithversion" />
    -        <param name="version" value="1.1.1" />
    -    </feature>
    -    <feature name="A feature with url and version">
    -        <param name="id" value="org.apache.cordova.featurewithurlandversion" />
    -        <param name="version" value="1.1.1" />
    -        <param name="url" value="http://cordova.apache.org/featurewithurlandversion"
/>
    -    </feature>
    -    <feature name="A simple feature">
    -        <param name="id" value="org.apache.cordova.justafeature" />
    +    <plugin name="org.apache.cordova.featurewithvars">
    +        <variable name="var" value="varvalue" />
    +    </plugin>
    +    <plugin name="org.apache.cordova.featurewithurl" src="http://cordova.apache.org/featurewithurl"
/>
    +    <plugin name="org.apache.cordova.featurewithversion" version="1.1.1" />
    +    <plugin name="org.apache.cordova.featurewithurlandversion" src="http://cordova.apache.org/featurewithurlandversion"
version="1.1.1" />
    +    <plugin name="org.apache.cordova.justafeature" />
    --- End diff --
    
    never mind. we apparently use 'src' for both url and folder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message