cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...
Date Mon, 09 Mar 2015 17:53:12 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/178#discussion_r26058485
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -134,7 +135,7 @@ module.exports = function plugin(command, targets, opts) {
     
                             // Fetch the plugin first.
                             events.emit('verbose', 'Calling plugman.fetch on plugin "' +
target + '"');
    -                        return plugman.raw.fetch(target, pluginsDir, { searchpath: searchPath,
noregistry: opts.noregistry, link: opts.link, pluginInfoProvider: pluginInfoProvider});
    +                        return plugman.raw.fetch(target, pluginsDir, { searchpath: searchPath,
noregistry: opts.noregistry, link: opts.link, pluginInfoProvider: pluginInfoProvider, variables:
opts.cli_variables });
    --- End diff --
    
    Nit: Consider splitting this into two lines - it's rather wide currently - preventing
readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message