cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Fix issue where android cordov...
Date Wed, 04 Mar 2015 16:28:13 GMT
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77190993
  
    Change looks awesome! It's a bit much to pull in all at once though. Could you rebase
this into three distinct commits (error msgs, dropbox fix, gallery param)?
    
    Wondering if you'd also like to send a PR to improve the URL->filePath logic in cordova-android's
[CordovaResourceApi class](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaResourceApi.java#L143)?
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message