cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...
Date Tue, 03 Mar 2015 23:17:18 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25738050
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -236,15 +231,22 @@ function initSettings() {
         module.exports.settings =
         rc('plugman', {
             cache: plugmanCacheDir,
    -        registry: 'http://registry.cordova.io',
    +        registry: registryURL,
             logstream: fs.createWriteStream(path.resolve(plugmanConfigDir, 'plugman.log')),
             userconfig: path.resolve(plugmanConfigDir, 'config'),
             'cache-min': oneDay
         });
    +
    +    // if npm is true, use npm registry. 
    +    // ~/.plugman/config overides the above config if it exists. 
    --- End diff --
    
    I think custom registry should still work. 
    
    Ex: `plugman config set registry "MYSPECIALREGISTRY"`
    This updates the registry field in `~/.plugman/config`
    
    By the time the code hits line 243, the registry value equals the registry value from
config. If npm is true, then it would set it to use npm. But this is currently set to happen
on the fail (fallback). 
    
    So it would hit custom registry and then fallback to npm. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message