cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <>
Subject [GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...
Date Tue, 03 Mar 2015 20:52:38 GMT
Github user agrieve commented on a diff in the pull request:
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -236,15 +231,22 @@ function initSettings() {
         module.exports.settings =
         rc('plugman', {
             cache: plugmanCacheDir,
    -        registry: '',
    +        registry: registryURL,
             logstream: fs.createWriteStream(path.resolve(plugmanConfigDir, 'plugman.log')),
             userconfig: path.resolve(plugmanConfigDir, 'config'),
             'cache-min': oneDay
    +    // if npm is true, use npm registry. 
    +    // ~/.plugman/config overides the above config if it exists. 
    --- End diff --
    I think it's the same that Tim points out. Normally users don't have a registry override
in their plugman/config, but when they do, we should use it. Probably the logic should actually
    if (custom registry) {
      use it only
    } else {
      try CPR and fallback to NPM
    It's pretty fringe though, so maybe just add a TODO to support custom registries again?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message