cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...
Date Tue, 03 Mar 2015 19:58:28 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25720721
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -218,10 +205,18 @@ module.exports = {
     
     /**
      * @method initSettings
    + * @param {Boolean} using npm registry
      * @return {Promise.<Object>} Promised settings.
      */
    -function initSettings() {
    +function initSettings(npm) {
         var settings = module.exports.settings;
    +    var registryURL = 'http://registry.cordova.io';
    +
    +    //if npm is true, use npm registry
    +    if(npm) {
    +        registryURL = 'http://registry.npmjs.org';
    +    }
    +
    --- End diff --
    
    TBH, I prefer `if(npm) {...}` to `?`. I think it is just easier to read and leaves us
open to add other changes if we realize we need to. If I am unaware of some performance boost
or something, please let me know. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message