cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...
Date Tue, 03 Mar 2015 19:43:11 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25719212
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -147,6 +146,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
             checkID(options.expected_id, result.pinfo);
             metadata.save_fetch_metadata(plugins_dir, result.pinfo.id, { source: result.fetchJsonSource
});
             return result.dest;
    +    })            
    +    .fail(function(error) {
    --- End diff --
    
    I'm not 100% sure, but I think I needed to add this during one of my iterations. It very
well could be no-op now. I will see if I can hit it and if it is needed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message