cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...
Date Tue, 03 Mar 2015 09:12:18 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/175#discussion_r25672017
  
    --- Diff: cordova-lib/src/plugman/registry/registry.js ---
    @@ -236,15 +231,22 @@ function initSettings() {
         module.exports.settings =
         rc('plugman', {
             cache: plugmanCacheDir,
    -        registry: 'http://registry.cordova.io',
    +        registry: registryURL,
             logstream: fs.createWriteStream(path.resolve(plugmanConfigDir, 'plugman.log')),
             userconfig: path.resolve(plugmanConfigDir, 'config'),
             'cache-min': oneDay
         });
    +
    +    // if npm is true, use npm registry. 
    +    // ~/.plugman/config overides the above config if it exists. 
    +    // Need to reset the registry value in settings 
    +    if(npm) {
    +        settings.registry = 'http://registry.npmjs.org';
    --- End diff --
    
    There's no way to avoid this being overwritten in the first place? If not, rather than
duplicating the string, can you either:
    
    1. Store this string in a variable and use the variable twice.
    2. Simply use the existing registryURL here (since it must be set to the npm registry).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message