cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8577 BugFix 'cordova plugin add <plug...
Date Mon, 02 Mar 2015 06:09:50 GMT
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/174#issuecomment-76663106
  
    @gorkem, the change you've committed to fix this issue ( https://github.com/apache/cordova-lib/commit/4c0fec7d30df238cfc4c834a4235b2c8fcf330ad
) introduces another bug : the variables list now contains all the `<param>` such as
'id', 'url', 'installPath', which is not correct !
    
    This is exactly the kind of subtle bugs I was afraid would sneak in if we used the approach
you're currently using to fix this issue.
    
    Related PR, with alternative fix : https://github.com/apache/cordova-lib/pull/174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message