cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hu, Ningxin" <ningxin...@intel.com>
Subject RE: crosswalk engine plugin for Cordova Android 4.0.0 release
Date Thu, 26 Mar 2015 06:54:53 GMT
> 
> Published it to npm!
> 
> https://www.npmjs.com/package/cordova-plugin-crosswalk-webview

It works like a charm!

> 
> Once a CLI release happens, we can update the docs to install it via plugin ID.

It sounds good!

> 
> On Wed, Mar 25, 2015 at 8:56 AM, Ian Clelland <iclelland@chromium.org>
> wrote:
> 
> > Once we publish this to npm (or the Cordova plugin registry) it will
> > be much smaller; just containing the code that is absolutely required
> > for the current version.
> >
> > I think that the only reasonable way to make the git repo itself
> > smaller would be to move it to a new location (new name or new
> organization).
> >
> > We (Google's team) have used cordova-crosswalk-engine as a git
> > submodule dependency for some time, in our mobile-chrome-apps repo,
> > and I don't think we can just rewrite all of the old commits without
> > also breaking all of our historical dependencies as well. (Filtering
> > the repo like this will rewrite a large number of commits, which will
> > certainly change their hashes, unfortunately).

Understood, thanks for your explanation.

Thanks,
-ningxin

> >
> > I'll do a bit more investigation today, but I think that the best
> > solution, for almost all users, is to publish just the current source
> > as a real cordova plugin, and not worry too much about the size of the
> > git repo, as it only affects people who are actively developing on it.
> > (And the size is no longer growing at that rate, so it is really only
> > a one-time checkout
> > cost)
> >
> > Ian
> >
> > On Wed, Mar 25, 2015 at 1:09 AM, Hu, Ningxin <ningxin.hu@intel.com>
> wrote:
> >
> > > >
> > > > Could this be fixed on plugman's side with git clone --depth 1?
> > >
> > > It still downloads 63MB.
> > >
> > > In my experiment, I delete all unused branches, tags, and remove
> > > related git objects. It can shrink the repo to 340KB with full
> > > history of master branch.
> > >
> > > There is a good reference for git repo shrinking:
> > >
> > https://www.rallydev.com/community/engineering/shrinking-git-repositor
> > y-move-githubcom
> > >
> > > Thanks,
> > > -ningxin
> > >
> > > >
> > > > On Tue, Mar 24, 2015 at 9:02 AM, Ian Clelland
> > > > <iclelland@chromium.org>
> > > > wrote:
> > > >
> > > > > On Tue, Mar 24, 2015 at 6:15 AM, Hu, Ningxin
> > > > > <ningxin.hu@intel.com>
> > > > wrote:
> > > > >
> > > > > > Crosswalk engine plugin is expected to work with upcoming
> > > > > > Cordova Android
> > > > > > 4.0.0 release.
> > > > > >
> > > > > > As I investigate, there are some issues need to be fixed:
> > > > > > 1.  Update the README.md of cordova-crosswalk-engine. E.g no
> > > > > fetch_libs.sh
> > > > > > anymore. I managed to create a PR for this:
> > > > > > https://github.com/MobileChromeApps/cordova-crosswalk-
> > > > engine/pull/20
> > > > > >
> > > > >
> > > > >  Thanks, Ningxin -- that's great! I'll merge it in.
> > > > >
> > > > > 2. Shrink the repo size: e.g remove unnecessary  libxwalkcore.so
> > etc.,
> > > > > It
> > > > > > impacts the plugin installation performance from github.com.
> > Please
> > > > > refer
> > > > > > to https://github.com/huningxin/cordova-crosswalk-engine-1.
It
> > > > > > shrinks from 118MB to 340KB.
> > > > > >
> > > > >
> > > > > I'll have to filter-repo on this; I'm not sure if there will be
> > > > > any disruption to the GitHub repository because of it, but I'll
> > > > > do my
> > best
> > > > > to minimize that. I agree that it has become unnecessarily large
> > > > > because of the included (and often updated) binary packages.
> > > > >
> > > > >
> > > > > >
> > > > > > Any other issues?
> > > > > >
> > > > > > Thanks,
> > > > > > -ningxin
> > > > > >
> > > > > >
> > > > > >
> > --------------------------------------------------------------------
> > > > > > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > > > > For additional commands, e-mail: dev-help@cordova.apache.org
> > > > > >
> > > > > >
> > > > >
> > >
> > > --------------------------------------------------------------------
> > > - To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > > For additional commands, e-mail: dev-help@cordova.apache.org
> > >
> >
Mime
View raw message