cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Paveza <Rob.Pav...@microsoft.com>
Subject RE: [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...
Date Thu, 12 Mar 2015 06:17:06 GMT
Only question is if callback.status might be undefined (stands to reason if it can be null).
 If so, the present check is insufficient and changes because you test with ===.

-Rob

-----Original Message-----
From: robpaveza [mailto:git@git.apache.org] 
Sent: Wednesday, March 11, 2015 11:14 PM
To: dev@cordova.apache.org
Subject: [GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
  
    --- Diff: cordova-js-src/exec.js ---
    @@ -60,18 +60,32 @@ module.exports = function (success, fail, service, action, args) {
                 // CB-5806 [Windows8] Add keepCallback support to proxy
                 onSuccess = function (result, callbackOptions) {
                     callbackOptions = callbackOptions || {};
    +                var callbackStatus;
    +                if (callbackOptions.status !== null) {
    --- End diff --
    
    Is undefined a possible value here?


---
If your project is set up for it, you can reply to this email and have your reply appear on
GitHub as well. If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at infrastructure@apache.org
or file a JIRA ticket with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message