Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6DD901086C for ; Wed, 18 Feb 2015 20:23:46 +0000 (UTC) Received: (qmail 87009 invoked by uid 500); 18 Feb 2015 20:23:46 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 86962 invoked by uid 500); 18 Feb 2015 20:23:46 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 86951 invoked by uid 99); 18 Feb 2015 20:23:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 20:23:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6C7CDE03C8; Wed, 18 Feb 2015 20:23:45 +0000 (UTC) From: jbuck To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-firefoxos pull request: CB-7567 Don't use adm-zip because ... Content-Type: text/plain Date: Wed, 18 Feb 2015 20:23:45 +0000 (UTC) GitHub user jbuck opened a pull request: https://github.com/apache/cordova-firefoxos/pull/22 CB-7567 Don't use adm-zip because it creates invalid zip files This patch is a fix for [CB-7567](https://issues.apache.org/jira/browse/CB-7567) where the current build step using [adm-zip creates invalid zip files](https://github.com/cthackers/adm-zip/issues/71). I switched to archiver because that's what our projects after_build script use, and what [cordova-browser uses](https://github.com/apache/cordova-browser/pull/10). @stevengill I haven't contributed to Apache Cordova before. I know I need to sign the CLA. Is there anything else I need to do from a contribution standpoint? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbuck/cordova-firefoxos fix-zip Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-firefoxos/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 ---- commit bd21ce3b06db8ee6315c6ad591eef2f18265c037 Author: Jon Buckley Date: 2015-02-18T16:13:43Z CB-7567 Don't use adm-zip because it creates invalid zip files ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org