Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates
 209.85.213.170 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: 
 <CAKP6k2sTy-Qp2gE2+8Wc=wPE9npOECzx1dd+iPhF32qaZ12h6g@mail.gmail.com>
References: 
 <CABiQX1VaFQUtnFUAnrG4tV5mXNHymPHu3CMOcZKr9H0B4zA2vw@mail.gmail.com>
 <SN2PR03MB0324235E7FCC1D7B99F73D9B8250@SN2PR03MB032.namprd03.prod.outlook.com>
 <CABiQX1VrX3PhfuF-KJeSvgxe8LrbAz8r-G5QWew8Q_fbgKBZaA@mail.gmail.com>
 <CAOBL_k6-zOh5ucXy53ueSYE4Ms--nwbNpjDATVbgHhRgEbtH0A@mail.gmail.com>
 <CAOBL_k6Sxp4LE1H9RCTyKporSiEG1vJ1fijPCEq=vHLgRXE3Sg@mail.gmail.com>
 <CAKP6k2sTy-Qp2gE2+8Wc=wPE9npOECzx1dd+iPhF32qaZ12h6g@mail.gmail.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Wed, 11 Feb 2015 21:34:32 -0500
Message-ID: 
 <CABiQX1VJ1-HoGY4EGu7dOqqUPR7O-GnQSBtqZRBYtg+=Cx_GUQ@mail.gmail.com>
Subject: Re: Android JUnit Tests Now Pass
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=bcaec5158d91f3de10050edaf6ff

--bcaec5158d91f3de10050edaf6ff
Content-Type: text/plain; charset=UTF-8

On Wed, Feb 11, 2015 at 5:00 PM, Jesse <purplecabbage@gmail.com> wrote:

> +1 Revert
>
> And please let's stop deleting what other people wrote just because we
> don't recognize it. These things should require discussion.
>

Bit of a jump to conclusions, don't you think? What makes you think I don't
recognize the code I changed?


>
> @purplecabbage
> risingj.com
>
> On Wed, Feb 11, 2015 at 1:53 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
> > I think we should revert this refactor.  With the new refactored tests,
> > they may pass but we lost a lot of the useful tests that we once had and
> > these new tests have no value.  I don't know why you took it upon
> yourself
> > to throw away all the JUnit tests that didn't pass, but that misses the
> > point.  I would have rather had the old tests expanded upon instead of
> just
> > deleted on your personal whim.
> >
> > I honestly don't know what to say, I know that we have a terrible working
> > relationship at best, but this actually is making the project worse
> > intentionally for unknown reasons.  In fact, I would almost say that this
> > is purely a malicious change driven by ego, since I can't see a technical
> > reason for any of it.
> >
> > On Wed Feb 11 2015 at 1:36:19 PM Joe Bowser <bowserj@gmail.com> wrote:
> >
> > > I think there's a lot of value in the Unit Tests, having wrote the
> > > majority of them initially.  If I wasn't dealing with everyone in my
> > house
> > > getting sick, I'd check to make sure these tests were still testing
> what
> > I
> > > intended them to test, since we have a habit of losing the intent
> behind
> > > the test every time we do a refactor.
> > >
> > > Of course, if we're going to throw away the embedded WebView case, then
> > > maybe there's not value after all.
> > >
> > > On Wed Feb 11 2015 at 1:12:29 PM Andrew Grieve <agrieve@chromium.org>
> > > wrote:
> > >
> > >> Does travis provide Android emulators? I'd guess it'd be too slow to
> put
> > >> on
> > >> Travis. And honestly, there's still not a lot of value in the unit
> tests
> > >> atm.
> > >>
> > >> On Wed, Feb 11, 2015 at 3:12 PM, Murat Sutunc <muratsu@microsoft.com>
> > >> wrote:
> > >>
> > >> > This is great news!
> > >> > I've finally got the android travis enabled too. We have jshint and
> > >> > jasmine test coverage on every commit now. (
> > >> > https://travis-ci.org/apache/cordova-android/builds/50295748)
> > >> >
> > >> > Now that we're passing all junit tests, I think the next step for us
> > >> > should be to integrate junit tests with travis. What do you think?
> > >> >
> > >> > -----Original Message-----
> > >> > From: agrieve@google.com [mailto:agrieve@google.com] On Behalf Of
> > >> Andrew
> > >> > Grieve
> > >> > Sent: Tuesday, February 10, 2015 7:14 PM
> > >> > To: dev
> > >> > Subject: Android JUnit Tests Now Pass
> > >> >
> > >> > Spent some time cleaning up the tests. Certainly they could be made
> > even
> > >> > better & made to test more things, but at least they pass now :)
> > >> >
> > >> > Much of the change was deleting copy & paste, and deleting commented
> > out
> > >> > tests:
> > >> > 53 files changed, 941 insertions(+), 2610 deletions(-)
> > >> >
> > >> >
> ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > >> > For additional commands, e-mail: dev-help@cordova.apache.org
> > >> >
> > >>
> > >
> >
>

--bcaec5158d91f3de10050edaf6ff--