Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-170-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-170-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-8499 `cordova platform save`
 should s...
Content-Type: text/plain
Message-Id: <20150223174642.7151FE04D1@git1-us-west.apache.org>
Date: Mon, 23 Feb 2015 17:46:42 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/170#discussion_r25184230
  
    --- Diff: cordova-lib/src/cordova/platform_metadata.js ---
    @@ -0,0 +1,102 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +
    +var path         = require('path'),
    +    cordova_util = require('./util'),
    +    fs           = require('fs'),
    +    Q            = require('q'),
    +    shelljs      = require('shelljs');
    +
    +
    +// Retrieves the platforms and their versions from the platforms.json file
    +// Returns an array of {platform: platform, version: version} ...
    +// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
    +function getVersions(projectRoot) {
    +    var platformsDir = path.join(projectRoot, 'platforms');
    +    var platformsJsonFile = path.join(platformsDir, 'platforms.json');
    +
    +    // If the platforms.json file doesn't exist, retrieve versions from platforms installed on the filesystem...
    +    // ...Note that in this case, we won't be able to know what source(folder, git-url) the platform came from, we'll just use versions
    +    return getPlatVersionsFromFile(platformsJsonFile).fail(function(){
    +        return getPlatVersionsFromFileSystem(projectRoot);
    +    });
    +}
    +
    +// Returns a promise
    +function getPlatVersionsFromFile(platformsJsonFile){
    +    var platformData = require(platformsJsonFile);
    --- End diff --
    
    Why do a require to a data file? JSON.parse is better as it prevents arbitrary code from being loaded.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org