Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD9F817A02 for ; Fri, 13 Feb 2015 00:52:53 +0000 (UTC) Received: (qmail 62028 invoked by uid 500); 13 Feb 2015 00:52:19 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 61987 invoked by uid 500); 13 Feb 2015 00:52:19 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 61975 invoked by uid 99); 13 Feb 2015 00:52:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Feb 2015 00:52:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0488CE01BD; Fri, 13 Feb 2015 00:52:19 +0000 (UTC) From: stevengill To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib commit comment: adab8c9accfd769019837bb1cc36a2975f9742... Content-Type: text/plain Message-Id: <20150213005219.0488CE01BD@git1-us-west.apache.org> Date: Fri, 13 Feb 2015 00:52:19 +0000 (UTC) Github user stevengill commented on commit adab8c9accfd769019837bb1cc36a2975f9742b0: https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9728548 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 93: Yeah, I'd say it is fine. Alternative is to move it out of the plugin directory but we probably want to keep the file nearby incase errors occur. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org