Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-166-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-166-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: Save/Restore for plugins and
 platforms
Content-Type: text/plain
Message-Id: <20150212202833.3745DE03A1@git1-us-west.apache.org>
Date: Thu, 12 Feb 2015 20:28:33 +0000 (UTC)

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/166#issuecomment-74146324
  
    'saving to config.xml' should happen after the plugin has been installed on the platforms. 
    That way, if any error is encountered during the install, the config.xml does not get updated.
    What do you think ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org