Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B7E610BA6 for ; Thu, 12 Feb 2015 20:22:37 +0000 (UTC) Received: (qmail 86499 invoked by uid 500); 12 Feb 2015 20:22:37 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 86449 invoked by uid 500); 12 Feb 2015 20:22:37 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 86437 invoked by uid 99); 12 Feb 2015 20:22:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Feb 2015 20:22:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 69CF6E03A1; Thu, 12 Feb 2015 20:22:36 +0000 (UTC) From: omefire To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: Save/Restore for plugins and platforms Content-Type: text/plain Message-Id: <20150212202236.69CF6E03A1@git1-us-west.apache.org> Date: Thu, 12 Feb 2015 20:22:36 +0000 (UTC) Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/166#issuecomment-74145216 I think the 'saving to config.xml' should be moved into a separate function and called from here. this function is getting way too long to easily reason about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org