Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 947A010922 for ; Mon, 9 Feb 2015 15:31:19 +0000 (UTC) Received: (qmail 8703 invoked by uid 500); 9 Feb 2015 15:31:19 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 8664 invoked by uid 500); 9 Feb 2015 15:31:19 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 8653 invoked by uid 99); 9 Feb 2015 15:31:18 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 15:31:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9619EE01CE; Mon, 9 Feb 2015 15:31:18 +0000 (UTC) From: gorkem To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio... Content-Type: text/plain Message-Id: <20150209153118.9619EE01CE@git1-us-west.apache.org> Date: Mon, 9 Feb 2015 15:31:18 +0000 (UTC) Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863 IMHO it is(or was) premature to drop this single PR by itself to master. This new flag --save flag should replace the save command, save command is not removed by this PR. Consequently the existing tests for save command should also be modified/replaced to work with this new function. Also without the corresponding restore functionality --save is useless to CLI users. I think we should refrain from releasing it until restore is taken to master too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org