cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From herrevilkitten <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB 8467
Date Sat, 14 Feb 2015 21:21:47 GMT
GitHub user herrevilkitten opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/81

    CB 8467

        Added support for hiding the web view container.  This maintains the browser
        session without closing it.  The browser window can be repeatedly hidden and
        shown.
        
        ** This has only been tested on android and ios **
        
        amazon/android:
        An additional `hide` action was added to `InAppBrowser#execute`.  It is
        identical to `show`, except that it calls `dialog.hide()` instead.
        
        blackberry10:
        no changes
        
        firefoxos:
        Added a `hide` method that is identical to `show`, indicating it is not
        supported.
        
        ios:
        Added a `hide` method that is identical to `show`, except that it uses
        `dismissViewControllerAnimated`.  It checks the value of
        `_previousStatusBarStyle`.  If it is `-1`, the method returns with no
        action performed.  If it is not, it is set to `-1.`
        
        ubuntu:
        Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to
        `false`.
        
        windows:
        Added a `hide` method that sets `browserWrap.style.display` to `none`.
        
        wp:
        Added a `hide` method that is identical to `show`, except that it sets
        `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to
        `false`.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/herrevilkitten/cordova-plugin-inappbrowser CB-8467

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
    
----
commit 72defbe44f39ea3aff8a79ca0c5556d054dbbf35
Author: ekidder3 <eric.kidder@gtri.gatech.edu>
Date:   2015-02-05T12:20:57Z

    CB-8467
    
    Added support for hiding the web view container.  This maintains the browser
    session without closing it.  The browser window can be repeatedly hidden and
    shown.
    
    ** This has only been tested on android and ios **
    
    amazon/android:
    An additional `hide` action was added to `InAppBrowser#execute`.  It is
    identical to `show`, except that it calls `dialog.hide()` instead.
    
    blackberry10:
    no changes
    
    firefoxos:
    Added a `hide` method that is identical to `show`, indicating it is not
    supported.
    
    ios:
    Added a `hide` method that is identical to `show`, except that it uses
    `dismissViewControllerAnimated`.  It checks the value of
    `_previousStatusBarStyle`.  If it is `-1`, the method returns with no
    action performed.  If it is not, it is set to `-1.`
    
    ubuntu:
    Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to
    `false`.
    
    windows:
    Added a `hide` method that sets `browserWrap.style.display` to `none`.
    
    wp:
    Added a `hide` method that is identical to `show`, except that it sets
    `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to
    `false`.

commit 3f3a8e25fef5acd9f379caf6a68737acd24d149c
Author: ekidder3 <eric.kidder@gtri.gatech.edu>
Date:   2015-02-13T12:24:26Z

    Changed www/windows8/InAppBrowserProxy.js to have a `hide` method

commit 410428f72dfc0aefe2f02ae95b87ac88adf99ae4
Author: ekidder3 <eric.kidder@gtri.gatech.edu>
Date:   2015-02-13T12:24:26Z

    Changed www/windows8/InAppBrowserProxy.js to have a `hide` method

commit 823232b3dc40d9312e867f9adfc6738576207cdd
Author: ekidder3 <eric.kidder@gtri.gatech.edu>
Date:   2015-02-14T21:17:38Z

    Merge branch 'origin/CB-8467' of github.com:herrevilkitten/cordova-plugin-inappbrowser
into origin/CB-8467

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message