cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...
Date Fri, 06 Feb 2015 07:59:31 GMT
GitHub user vladimir-kotikov opened a pull request:

    CB-8407 Fix downloading of ms-appdata:/// urls on Windows

    JIRA issue [CB-8407](
    download() in file-transfer plugin expects path instead of internal URL on windows
    This bug seems to be introduced with these changes to cordova-plugin-file:
    All tests for download method of file-transfer plugin now fail on windows with following
    Exception calling native with command :: FileTransfer :: download ::exception=WinRTError:
The parameter is incorrect.

You can merge this pull request into a Git repository by running:

    $ git pull CB-8407

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
commit 0394c0ce1eaf60f93ef1d529bc2fe1634d5d33da
Author: Vladimir Kotikov <>
Date:   2015-02-03T12:50:31Z

    CB-8407 Removes excess path to native path conversion in download method
    This fixes file transfer download tests failures, when target file is specified by ms-appdata:///
uri on Windows.

commit 7a93626812522e473248c7629238da81d03fb805
Author: Vladimir Kotikov <>
Date:   2015-02-03T14:06:14Z

    CB-8407 Use File proxy to construct valid FileEntry for download success callback
    Due to changes in file plugin (
result of download method should now have filesystemName specified for proper work. This updates
download method to construct FileEntry properly, using File plugin proxy.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message