cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gorkem <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Save/Restore for plugins and platforms
Date Thu, 12 Feb 2015 16:52:55 GMT
GitHub user gorkem opened a pull request:

    https://github.com/apache/cordova-lib/pull/166

    Save/Restore for plugins and platforms

    I think this is a good point to merge these features.. It provides most of the functionality
and frankly I am tired of rebasing/merging.
    
    Several features implemented. 
    1. Implements auto-restore for platforms and plugins on prepare. Platforms are only restore
when a platforms is specifically requested.
    2. Implements --save flag for cordova plugins add/rm
    3. removes the old save and restore commands
    4. removes the old tests for save and restore 
    
    What is missing:
    1. Switch to plugin tag on config.xml. ( Another PR is coming for that shortly)
    2. tests for --save flag
    3. tests for autorestore


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gorkem/cordova-lib save_restore_final

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #166
    
----
commit 037a5c2eae54d9ea69c71185ec2c7d78c500fb9a
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2015-02-10T00:48:48Z

    remove save and restore commands
    
    removes save.js and restore.js and references to those files

commit a70ae2d0c3927cbb6bdb1dc214db469ea74086dd
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2015-02-10T00:50:43Z

    restore plugins and platforms on prepare
    
    Collect the restore logic to restore-util.js and uses it from prepare to restore plugins
and
    platforms during prepare

commit 07e3862fd928248b7b8d63a9da2ca374d9e5c528
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2015-02-10T01:01:47Z

    remove save and restore tests

commit ce976e93d4a5adb540af685cf0f171f14e54d73a
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2015-02-11T19:00:50Z

    fix for test after prepare changes
    
    restore util.cdProjectRoot which prepare depends on to generate correct error message.

commit d899bc23536449749586a00a6c1765f2950c03ef
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2015-02-12T16:26:25Z

    --save flag for plugins
    
    save implementation for adding or removing plugins

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message