cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Create a new abstraction for sharing...
Date Thu, 19 Feb 2015 17:10:58 GMT
GitHub user agrieve opened a pull request:

    https://github.com/apache/cordova-android/pull/158

    Create a new abstraction for sharing common logic of WebView engines.

    Having CordovaWebViewImpl separate from CordovaWebViewEngine is helpful because
    now each webview doesn't have to re-implement non-webview-specific
    featrues. e.g.:
    1. load timeout
    2. keyboard events
    3. showCustomView
    4. lifecycle events
    
    Moved AndroidWebView into its own package to ensure that it doesn't use
    any package-private symbols (since plugins cannot use them).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agrieve/cordova-android engine

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #158
    
----
commit 1b79a34d5f5a7506db94cf7a799f976e52b9b764
Author: Andrew Grieve <agrieve@chromium.org>
Date:   2015-02-06T01:46:42Z

    Create a new abstraction for sharing common logic of WebView engines.
    
    Having CordovaWebViewImpl separate from CordovaWebViewEngine is helpful because
    now each webview doesn't have to re-implement non-webview-specific
    featrues. e.g.:
    1. load timeout
    2. keyboard events
    3. showCustomView
    4. lifecycle events
    
    Moved AndroidWebView into its own package to ensure that it doesn't use
    any package-private symbols (since plugins cannot use them).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message