cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: Found a regression in cordova-android@3.7.0
Date Tue, 03 Feb 2015 23:37:35 GMT
Nice catch. I will patiently wait until this is ready before I move on this
release (release issue: https://issues.apache.org/jira/browse/CB-8415)

On Tue, Feb 3, 2015 at 3:31 PM, Murat Sutunc <muratsu@microsoft.com> wrote:

> Looks like this fix broke `cordova build` for windows:
>
> :CordovaLib:compileDebugJava
> C:\dev\test\platforms\android\CordovaLib\src\org\apache\cordova\CordovaActivity.java:151:
> error: method init in interface CordovaWebView cannot be applied to given
> types;
>         appView.init(this, pluginEntries, internalWhitelist,
> externalWhitelist, preferences);
>                ^
>   required:
> CordovaInterface,List<PluginEntry>,Whitelist,Whitelist,CordovaPreferences
>   found:
> CordovaActivity,ArrayList<PluginEntry>,Whitelist,Whitelist,CordovaPreferences
>   reason: actual argument CordovaActivity cannot be converted to
> CordovaInterface by method invocation conversion
> C:\dev\test\platforms\android\CordovaLib\src\org\apache\cordova\CordovaActivity.java:217:
> error: cannot find symbol
>         return ret;
>                ^
>   symbol:   variable ret
>   location: class CordovaActivity
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> 2 errors
> :CordovaLib:compileDebugJava FAILED
>
> FAILURE: Build failed with an exception.
>
> * What went wrong:
> Execution failed for task ':CordovaLib:compileDebugJava'.
> > Compilation failed; see the compiler error output for details.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 3.117 secs
>
> C:\dev\test\platforms\android\cordova\node_modules\q\q.js:126
>                     throw e;
>                           ^
> Error code 1 for command: cmd with args: /s /c
> "C:\dev\test\platforms\android\gradlew cdvBuildDebug -b
> C:\dev\test\platforms\android\build.gradle -Dorg.gradle.daemon=true"
> ERROR building one of the platforms: Error:
> C:\dev\test\platforms\android\cordova\build.bat: Command failed with exit
> code 8
> You may not have the required environment or OS to build this project
>
> -----Original Message-----
> From: Joe Bowser [mailto:bowserj@gmail.com]
> Sent: Tuesday, February 3, 2015 1:41 PM
> To: dev@cordova.apache.org
> Subject: Re: Found a regression in cordova-android@3.7.0
>
> Was the plugin using public APIs? I'm fine with a 3.7.1, but I am less OK
> with calling this a regression if we never supported this.
>
> On Tue, 3 Feb 2015 1:38 pm Steven Gill <stevengill97@gmail.com> wrote:
>
> > Okay, lets get android 3.7.1 vote started, update blog post for 3.7.1
> > and publish it when vote is successful. Do tools release following
> > completion of 3.7.1 vote with 3.7.1 pinned.
> >
> > On Tue, Feb 3, 2015 at 1:09 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> >
> > > Regression: https://issues.apache.org/jira/browse/CB-8411
> > >
> > > Already applied the fix to the 3.7.x branch (and to master).
> > >
> > > Question is whether we should skip pinning of 3.7.0, and go straight
> > > to 3.7.1? Wouldn't take much extra effort, but we should hold off
> > > the blog post though.
> > >
> > > The bug breaks Telerik's NativePageTransitions plugin (
> > > https://github.com/Telerik-Verified-Plugins/NativePageTransitions)
> > > and potentially others?
> > >
> > > Thoughts?
> > >
> > >
> > > The good news is that I found the bug by adding a
> > > --thirdpartyplugins
> > flag
> > > to createmobilespec.js, which just adds in a bunch of other popular
> > plugins
> > > to the project. So, finding these sorts of breakages in the future
> > > will
> > be
> > > easier.
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message