cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chuck Lantz <cla...@microsoft.com>
Subject RE: Thoughts on CB-7827
Date Fri, 13 Feb 2015 14:56:46 GMT
To be clear, CB-6511 fixes app names that are non-English which is clearly not an edge case.
For example, previous to this change it was impossible to build an app for Android with a
Chinese display name. You'll note Cordova documentation is available in Chinese.

-Chuck

-----Original Message-----
From: Tommy Williams [mailto:tommy@devgeeks.org] 
Sent: Friday, February 13, 2015 6:04 AM
To: dev@cordova.apache.org
Subject: Re: Thoughts on CB-7827

Please someone fix this somehow :(

Is CB-6511 really important enough to cause this? It feels like an edge case caused an issue
for the majority.

- tommy
On 14 Feb 2015 12:32 am, "Connor Pearson" <cjp822@gmail.com> wrote:

> Hi all,
>
> I'm wondering what the status of CB-7827 is. It causes the APK and 
> activity name to be set to a hardcoded value. It's been open since 
> October and has more votes and watchers than any other Cordova bug.
>
> According to the Android documentation (
>
> http://android-developers.blogspot.com/2011/06/things-that-cannot-chan
> ge.html
> ),
> you should never change the android:name attribute. So developers 
> working on an already published app must perform a manual fix of 
> several files every time the android platform is added.
>
> The root cause of the issue is Cordova now hardcodes the main activity 
> name as CordovaApp (or MainActivity). This was done to fix CB-6511. I 
> have a couple of ideas for fixing this bug without regressing CB-6511:
>
> - Use the project name as the activity name then fall back to the 
> hardcoded name if the project name uses 16 bit characters.
>
> - Allow the user to specify android-activityName in config.xml. 
> Similar to android-versionCode.
>
> - Another option could be to combine the two, attempting to use 
> android-activityName first then falling back to the project name then 
> finally falling back the hardcoded name.
>
> Do you think any of these ideas are worth pursuing? I'd be willing to 
> work on a pull request, but I want to make sure I'm going in the right 
> direction.
>
> Thanks,
> Connor
>
Mime
View raw message