cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...
Date Mon, 23 Feb 2015 18:10:12 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/171#discussion_r25186284
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -521,19 +521,27 @@ function getCreateArgs(platDetails, projectRoot, cfg, template_dir,
opts) {
         if (/android|ios/.exec(platDetails.platform) && semver.gt(platDetails.version,
'3.3.0')) {
             args.push('--cli');
         }
    -
    +    
         var pkg = cfg.packageName().replace(/[^\w.]/g,'_');
         // CB-6992 it is necessary to normalize characters
         // because node and shell scripts handles unicode symbols differently
         // We need to normalize the name to NFD form since iOS uses NFD unicode form
         var name = platDetails.platform == 'ios' ? unorm.nfd(cfg.name()) : cfg.name();
         args.push(output, pkg, name);
    +
    +    var activityName = cfg.android_activityName();
    +    if (activityName && platDetails.platform === 'android') {
    +        activityName = activityName.replace(/W/g, '');
    +	args.push(activityName);
    --- End diff --
    
    We need this to continue to work for older versions of cordova-android. You should add
this arg only if:
    
        semver.gte(platDetails.version, '4.0.0-dev')


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message