cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-8499 `cordova platform save` should s...
Date Fri, 20 Feb 2015 19:36:01 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/platform_metadata.js ---
    @@ -0,0 +1,113 @@
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +var path         = require('path'),
    +    cordova_util = require('./util'),
    +    fs           = require('fs'),
    +    Q            = require('q'),
    +    shelljs      = require('shelljs'),
    +    events       = require('../events');
    +// Retrieves the platforms and their versions from the platforms.json file
    +// Returns an array of {platform: platform, version: version} ...
    +// ... where version could be '3.4.0', '/path/to/platform' or 'git://...'
    +function getVersions(projectRoot) {
    +    var platformsDir = path.join(projectRoot, 'platforms');
    +    var platformsJsonFile = path.join(platformsDir, 'platforms.json');
    +    // If the platforms.json file doesn't exist, retrieve versions installed
    +    // In this case, we won't be able to know what source the platform came from
    +    return Q.nfcall(fs.exists, platformsJsonFile).then(function(exists){
    --- End diff --
    Due to [](
    > fs.exists() is an anachronism and exists only for historical reasons. There should
almost never be a reason to use it in your own code.
    Probably it is better to replace this with something like this:
    return getPlatVersionsFromFile(platformsJsonFile)
    .fail(function () {
        return getPlatVersionsFromFileSystem(projectRoot);

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message