cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8499 `cordova platform save` should s...
Date Fri, 20 Feb 2015 19:19:09 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/170#discussion_r25095035
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -158,6 +160,11 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts)
{
                             return installPluginsForNewPlatform(platform, projectRoot, cfg,
opts);
                         }
                     }).then(function() {
    +                    // Save platform@version into platforms.json. i.e: 'android@https://github.com/apache/cordova-android.git'
    +                    // If no version was specified, save the edge version
    +                    var versionToSave = version ? version : platforms[platform].version;
    --- End diff --
    
    just a nitpick - there is no need for ternary operator, `version || platforms[platform].version`
will work the same way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message