cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmocny <>
Subject [GitHub] cordova-lib commit comment: fcf37d03d12301d26cb4bcbb0107b085325f40...
Date Mon, 09 Feb 2015 21:41:46 GMT
Github user mmocny commented on commit fcf37d03d12301d26cb4bcbb0107b085325f40d6:
    In cordova-lib/src/plugman/plugman.js:
    In cordova-lib/src/plugman/plugman.js on line 226:
    Nit: Pass in `cli_opts.argv.remain[0]` here, and change `createpackagejson` to accept
an actual path.
    If you actually do want multiple args, and want `createpackagejson` to do the arg parsing
(I don't think so), then change this variable name here at least to `args`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message