cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gorkem <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...
Date Mon, 09 Feb 2015 15:31:18 GMT
Github user gorkem commented on the pull request:

    https://github.com/apache/cordova-lib/pull/144#issuecomment-73527863
  
    IMHO it is(or was) premature to drop this single PR by itself to master. This new flag
--save flag should replace the save command, save command is not removed by this PR. Consequently
the existing tests for save command should also be modified/replaced to work with this new
function.
    
    Also without the corresponding restore functionality --save is useless to CLI users. I
think we should refrain from releasing it until restore is taken to master too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message