Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D56EC1763A for ; Wed, 28 Jan 2015 19:41:27 +0000 (UTC) Received: (qmail 64809 invoked by uid 500); 28 Jan 2015 19:41:28 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 64772 invoked by uid 500); 28 Jan 2015 19:41:27 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 64737 invoked by uid 99); 28 Jan 2015 19:41:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jan 2015 19:41:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3E892E03EE; Wed, 28 Jan 2015 19:41:11 +0000 (UTC) From: TimBarham To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-lib pull request: CB-8123 Plugin references can target spe... Content-Type: text/plain Date: Wed, 28 Jan 2015 19:41:11 +0000 (UTC) GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/155 CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `` and `` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms. Also adds support for `src` attribute as an alias for the `Include` attribute on the `` element (since `src` is documented, but `Include` is used by existing plugins). Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform). As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-8123-final Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 ---- commit 8b6f7b9b443fe6b35e070bd1ad8ff81df53f559f Author: Tim Barham Date: 2015-01-28T19:15:39Z CB-8123 Plugin references can target specific windows platforms. Adds support for `target`, `versions` and `arch` attributes on `` and `` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms. Also adds support for `src` attribute as an alias for the `Include` attribute on the `` element (since `src` is documented, but `Include` is used by existing plugins). Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform). As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files. Note that I plan to rename some windows8 files and folders to windows, and jsproj.js to jsprojManager.js in a subsequent commit. commit 48852eefb20840149fa9ada28082e6cb0a2ff208 Author: Tim Barham Date: 2015-01-28T19:30:27Z CB-8123 Rename windows platform related files. Renames `windows8` plugin platform folders in tests to `windows`. Renames `jsproj.js` to `jsprojManager.js`. commit 22a214f217014b8c2df0348025d734cdf03580a7 Author: Tim Barham Date: 2015-01-28T19:31:48Z CB-8123 Rename further windows platform related files. Renames `windows8.spec.js` to `windows.spec.js`. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org