Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of v-segreb@microsoft.com
 designates 157.56.110.136 as permitted sender)
From: "Sergey Grebnov (Akvelon)" <v-segreb@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: Cordova --list option implementation
Thread-Topic: Cordova --list option implementation
Thread-Index: AQHQKV/9XjSgdbogHk29A9kQLEQWu5yyy5Qw
Date: Tue, 6 Jan 2015 09:07:07 +0000
Message-ID: 
 <BL2PR03MB417ACE176CFBEEE3560C0759E590@BL2PR03MB417.namprd03.prod.outlook.com>
References: <D0D09373.861E%panarasi@microsoft.com>
In-Reply-To: <D0D09373.861E%panarasi@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2015 09:07:07.9981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB418
X-Virus-Checked: Checked by ClamAV on apache.org

In case of 1a "Ignoring unknown flags" approach I would also warn for each =
unknown parameter.

-Sergey
-----Original Message-----
From: Parashuram N (MS OPEN TECH) [mailto:panarasi@microsoft.com]=20
Sent: Tuesday, January 6, 2015 6:22 AM
To: dev
Subject: Cordova --list option implementation

Forking from Re: [DISCUSS] Tools Release to continue discussion.

+1 to Andrew suggestion that adding a top level command just for listing
targets would be an overkill. Also, people usually want to see the supporte=
d targets when they run, so it makes sense to expose it closer to where it =
gets used.

If we decide that cordova target add could be used to create new targets, t=
hat could be a separate top level command, can `cordova run <list` could be=
 the alias for `cordova target platform list` command (though I am not a fa=
n of aliasing commands).

Josh, is your concern that <list throws an error in case of blackberry? We =
could fix that by either

1a- Ignoring unknown flags like other platforms - and document the ignoring=
 part as the default behavior 1b - or change other platforms to throw error=
 on unsupported flags. In this case, <list would do the check to see if <li=
st is implemented first.

2. Implement <list for blackberry, thereby not having error on any platform=
. We could then have a separate discussion about what happens when a flag i=
s not supported by a platform.

It would be great if we can let users use the <list functionality with mini=
mal disruption to any platform.


On 1/5/15, 6:43 PM, "Andrew Grieve" <agrieve@chromium.org> wrote:

>Josh - thanks for pointing out that the change isn't working as intended.
>I
>did some testing before merging, but didn't try the error conditions.
>
>I've just reverted the one to CLI that enables the flag. Let's move=20
>forward with releasing :)
>
>Also noticed that if you have an older-than-master version of android=20
>installed in your project, then you get:
>
>$ cordova run --list
>Running command:
>/Users/agrieve/git/cordova/cordova-cli/foo/platforms/android/cordova/ru
>n
>--list
>ERROR : Run option '--list' not recognized.
>ERROR running one or more of the platforms: Error:
>/Users/agrieve/git/cordova/cordova-cli/foo/platforms/android/cordova/run:
>Command failed with exit code 2
>You may not have the required environment or OS to run this project
>
>I actually do like the syntax of "cordova run --list", since the run=20
>command is the thing that --target is relevant to anyways. Maybe=20
>"--list-targets" would be more explicit? Adding  "cordova target add"
>would
>be overstepping I think. You can add Android emulator targets as well,=20
>but us writing a wrapper for the logic would just make things more=20
>complicated I think.
>
>I do think that having cordova-lib look for the existence of the=20
>list-emulator-images and list-devices scripts makes sense, and just=20
>have it call them directly.
>
>
>On Mon, Jan 5, 2015 at 5:29 PM, Josh Soref <jsoref@blackberry.com> wrote:
>
>> Murat Sutunc wrote:
>> >1) When provided with an unknown extra parameter, such as --list in
>>this
>> >case, all the platforms ignore it. This looks like the expected
>>behavior
>> >as there are several issues in Jira related to it. (ex. See bug
>>CB-6676 -
>> >
>>=20
>>https://issues.apache.org/jira/browse/CB-6676?jql=3Dproject%20%3D%20CB%2
>>0AN
>>D
>> >%20text%20~%20%22ignore%20parameter%22). Exit code 1 on Blackberry
>>seems
>> >like a bug.
>>
>> https://wiki.apache.org/cordova/CommandLineToolingDesign#Errors
>>
>>
>> * 1: not implemented / unsupported command
>>
>>
>> I believe that what windows phone was doing was correct. And if=20
>>someone is  changing the contract, they failed to update the contract.
>>
>> >
>> >2) Introducing 'target' as a top level option seems like a new
>>proposal.
>> >My thoughts were to avoid having a new top level command for listing=20
>> >devices but I would like to hear others opinions on this as well. I
>>also
>> >think 'target' might not be the best choice of keyword here as it's=20
>> >already part of 'run' and it's easy to get confused:
>> >       cordova run --target=3DFOO
>> >       cordova target --list
>>
>> Not --list, just plain "list". As in "cordova platform list", and=20
>>"cordova  plugin list", it's a commonly used idiom in cordova.
>>
>> >3) I don=B9t understand the 'cordova target add' command completely.=20
>> >Is
>>it
>> >an alias to 'cordova platform add'?
>>
>> No.
>>
>> For blackberry10 you can configure a "target" which is a name for a=20
>>set of  settings (including an ip address/dns name, whether it is a =20
>>device/simulator, and a device password). You can then use run =20
>>--target=3Dfoo.
>>
>> >4) 'Each platform should already support the list-* commands' is=20
>> >currently not true. firefoxos, browser, Ubuntu don=B9t support it.
>>
>> Those platforms aren't complete, it's part of the contract, but we=20
>>already  have a good way of handling missing components of lib/ < if=20
>>they don't  exist (we can check for this), or aren't implemented (they=20
>>return a  standard value).
>>
>> The way you've implemented it with run, there's no way to look before=20
>>you  leap, which results in the failure that you introduced for=20
>>blackberry10.
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org