Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of muratsu@microsoft.com
 designates 207.46.100.119 as permitted sender)
From: Murat Sutunc <muratsu@microsoft.com>
To: "<dev@cordova.apache.org>" <dev@cordova.apache.org>
Subject: Re: File Transfer plugin and Crosswalk engine cookies
Thread-Topic: File Transfer plugin and Crosswalk engine cookies
Thread-Index: 
 AQHQNN9xHukZUYQDsUqgDEvSfGK2zpzJWcvvgAAW0gCACay0G4AAaDwAgAAIAsGAAAieAIAAhK0AgABHWc2AABIzAIAAAbyAgAALQMU=
Date: Tue, 27 Jan 2015 21:09:40 +0000
Message-ID: <A2A5FDEA-EC92-4CE8-9EF4-28066B904253@microsoft.com>
References: 
 <CA+z8NA_5J3UaTM7yk1=qfBSJY5mxy1rRzbAynXnZNcZ8k4anzA@mail.gmail.com>
	<CAOBL_k4tiU8fQgauyDYvofFBEUiimZTgGCqpcfE57xZpU+xNHA@mail.gmail.com>
	<CABiQX1X_c=p=DD4+3N8Cjy3cPWFoY5cS_xaZzCULp8Vv_1hmPA@mail.gmail.com>
	<CAOBL_k5nLOD7cqWLYH5_TjZRFaLtiuZL-K9PnA6YOs3EMmCa2A@mail.gmail.com>
	<BDD863A8AA703D4D8A2639FB639A44825747A2@shsmsx102.ccr.corp.intel.com>
	<CAOBL_k5hfsfBEBLW6vkoBUz+TUnzO7V441khbCR=Zxe032Ka2Q@mail.gmail.com>
	<1298B14A1D0704468AE73FC92557A162257EDDDF@SHSMSX104.ccr.corp.intel.com>
	<CABiQX1UBWUadPeiA541kgbOPk-CiLQmqzj9ODaM367p0obCiuA@mail.gmail.com>
	<CAOBL_k5M+rN7YJYuSBTSqcq5rVB+DNHO4UMzofFrTG=CgtRjLw@mail.gmail.com>
	<CABiQX1X0MLhHNJoGaKf0aDbD35og2Kdmi_MGTTj_G5L6_FDzcg@mail.gmail.com>,<CAKP6k2u+q_WDAkxXxf2=ckkLzVj7bn7uVF_LGmEb-CCds52u6g@mail.gmail.com>
In-Reply-To: 
 <CAKP6k2u+q_WDAkxXxf2=ckkLzVj7bn7uVF_LGmEb-CCds52u6g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2015 21:09:40.6709
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB029
X-Virus-Checked: Checked by ClamAV on apache.org

What exactly would this flag do underneath? I suppose it will add the cross=
walk plugin and run it's tests. Am I missing anything else?

> On Jan 27, 2015, at 12:29 PM, Jesse <purplecabbage@gmail.com> wrote:
>=20
> If you know there will be more, wouldn't it be simpler to just do somethi=
ng
> like :
> --webview=3Dcrosswalk // ?
>=20
> Just a small thing.
>=20
> @purplecabbage
> risingj.com
>=20
> On Tue, Jan 27, 2015 at 12:23 PM, Andrew Grieve <agrieve@chromium.org>
> wrote:
>=20
>> I think that would be manageable. Especially since right now there is on=
ly
>> 1.
>>=20
>>> On Tue, Jan 27, 2015 at 2:16 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>>=20
>>> I don't know if we want to do that, then we'd have to create flags for
>>> every potential third party webview.
>>>=20
>>> On Tue Jan 27 2015 at 7:03:28 AM Andrew Grieve <agrieve@chromium.org>
>>> wrote:
>>>=20
>>>> Sounds good. We should add a --crosswalk flag to createmobilespec.sh :=
)
>>>>=20
>>>>> On Tue, Jan 27, 2015 at 2:07 AM, Hu, Ningxin <ningxin.hu@intel.com>
>>>> wrote:
>>>>=20
>>>>> Hi Joe,
>>>>>=20
>>>>>>=20
>>>>>> Crosswalk has its own release schedule, so it should have its own
>>> test
>>>>> project
>>>>>> somewhere that tests the interfaces that it implements.  Of course,
>>>> this
>>>>>> would be similar to the ones that we still need to write for the
>>>>>> AndroidWebView.  That said, I think for now we should proceed with
>>> the
>>>>>> current tests and write the tests for 4.1.x
>>>>>>=20
>>>>>> This means that even if Crosswalk doesn't pass the JUnit tests, it
>>>> still
>>>>> won't
>>>>>> hold up the Cordova 4.0 release, because it's Crosswalk failing the
>>>>> tests, not
>>>>>> Cordova itself.  Being independent and interoperable is good,
>> since I
>>>>>> anticipate Crosswalk to release much more quickly than Cordova.
>>>>>=20
>>>>> It makes sense.
>>>>>=20
>>>>> From crosswalk-engine testing perspective, let's:
>>>>> 1. focus on mobile-spec integration test for Cordova 4.0 release
>>>>> 2. maintain the JUnit test project independently and align with 4.1.x
>>>>> development
>>>>>=20
>>>>> Please let us know if there are anything missed.
>>>>>=20
>>>>> Thanks,
>>>>> -ningxin
>>>>>=20
>>>>>>=20
>>>>>>> On Mon Jan 26 2015 at 10:14:11 PM Fu, Junwei <junwei.fu@intel.com>
>>>>>> wrote:
>>>>>>=20
>>>>>>> Crosswalk engine have been tested with mobile-spec and owned
>>>>>>> functionality test, but there are no JUnit test for Crosswalk
>>> engine,
>>>>>>> and the JUnit test in cordova-anroid 4.0 were being re-wrote.
>> Does
>>>> the
>>>>>>> Crosswalk engine need pass JUnit test before voting on releases?
>>>>>>> What's plan about making JUnit test cases to test pluggable
>>> webView.
>>>>>>>=20
>>>>>>> Thanks,
>>>>>>> Junwei.
>>>>>>>=20
>>>>>>> -----Original Message-----
>>>>>>> From: Joe Bowser [mailto:bowserj@gmail.com]
>>>>>>> Sent: Tuesday, January 27, 2015 7:55 AM
>>>>>>> To: dev
>>>>>>> Subject: Re: File Transfer plugin and Crosswalk engine cookies
>>>>>>>=20
>>>>>>> As far as I'm aware, we're basically waiting for this to be done
>>>>>>> before starting the vote thread.  Does this code exist yet?
>>>>>>>=20
>>>>>>> On Tue Jan 20 2015 at 12:12:22 PM Andrew Grieve <
>>>> agrieve@chromium.org>
>>>>>>> wrote:
>>>>>>>=20
>>>>>>>> I was planning on doing exactly what Darryl described. Would
>> love
>>>>>>>> such a PR! Note that we've just used this approach for the new
>>>>>>>> WebView security
>>>>>>>> hooks:
>>>>>>>>=20
>>>>>>>> https://github.com/apache/cordova-android/commit/
>>>>>>>> 623b394c830b8a83b5c2f16624d8013b6f851cd9
>>>>>>>> https://github.com/apache/cordova-android/commit/
>>>>>>>> 11002d4a56a4901087f514e2d01f8db392d0abe1
>>>>>>>>=20
>>>>>>>>=20
>>>>>>>> CookieManager has been exposed to plugins for a long time, and
>> it
>>>>>>>> would be crippling if FileTransfer could not set cookies.
>>>>>>>>=20
>>>>>>>>=20
>>>>>>>>=20
>>>>>>>> On Tue, Jan 20, 2015 at 1:48 PM, Joe Bowser <bowserj@gmail.com
>>>=20
>>>>>> wrote:
>>>>>>>>=20
>>>>>>>>> I think we should make the File Transfer plugin not need a
>>>>>>> CookieManager.
>>>>>>>>> It sounds like that's the bigger problem than it having to be
>>>> tied
>>>>>>>>> to a particular implementation of Cookies.
>>>>>>>>>=20
>>>>>>>>> On Tue Jan 20 2015 at 10:32:25 AM Darryl Pogue
>>>>>>>>> <dvpdiner2@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>=20
>>>>>>>>>> With the idea of preparing Cordova Android 4.0.x  for
>> release
>>>>>>>>>> starting to come up in discussions, I thought it was worth
>>>>>>>>>> raising this as a potential blocker.
>>>>>>>>>>=20
>>>>>>>>>> The file transfer plugin uses the Android webview cookie
>>>> manager.
>>>>>>>>>> When you're using a Crosswalk webview (or GeckoView
>>>> presumably),
>>>>>>>>>> in the best case there are no cookies with file transfer
>>>>>>>>>> requests and in the worst case it will cause the app to
>> crash
>>>> on
>>>>>>>>>> Android
>>>>>>> 4.2.x.
>>>>>>>>>>=20
>>>>>>>>>> There are a few existing bug reports and PRs related to
>> this,
>>>>>>>>>> but none of them propose a general solution for different
>>>>> webviews.
>>>>>>>>>> [1] [2] [3] [4]
>>>>>>>>>>=20
>>>>>>>>>> I was looking at this problem last week and the only
>> general
>>>>>>>>>> solution I could think of would involve adding a
>>>>>>>>>> CordovaCookieManager interface and implementing it for each
>>>>>>>>>> webview engine, which didn't seem to be the most idea
>>>> situation.
>>>>>>>>>>=20
>>>>>>>>>> I can write that interface and make a PR for it, but I'd
>>> rather
>>>>>>>>>> hear if anyone has better ideas before starting to make
>>> changes
>>>>>>>>>> across multiple repos.
>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>> [1]:
>> https://github.com/crosswalk-project/crosswalk-cordova-
>>>>>>>>>> android/pull/38
>>>>>>>>>> [2]:
>>> https://github.com/apache/cordova-plugin-file-transfer/pull/8
>>>>>>>>>> [3]:
>>>>>>>>>> https://github.com/MobileChromeApps/mobile-chrome-
>>>>>> apps/issues/46
>>>>>>>>>> 4
>>>>>>>>>> [4]:
>>>>>>>>>> https://github.com/gaochun/cordova-plugin-file-transfer/
>>>> commit/
>>>>>>>>>> 0063249e279b99a0feb4601650fc3a4c9e8a8ed2
>> ------------------------------------------------------------
>>>> ----
>>>>>>>>>> --
>>>>>>>>>> --- To unsubscribe, e-mail:
>>> dev-unsubscribe@cordova.apache.org
>>>>>>>>>> For additional commands, e-mail:
>> dev-help@cordova.apache.org
>>=20

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org