Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: agrieve <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-126-cordova-ios@git.apache.org>
In-Reply-To: <git-pr-126-cordova-ios@git.apache.org>
Subject: [GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios
 platfor...
Content-Type: text/plain
Message-Id: <20150121151218.1D082E03A1@git1-us-west.apache.org>
Date: Wed, 21 Jan 2015 15:12:18 +0000 (UTC)

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/126#discussion_r23305135
  
    --- Diff: bin/templates/scripts/cordova/lib/run.js ---
    @@ -0,0 +1,184 @@
    +/*
    +       Licensed to the Apache Software Foundation (ASF) under one
    +       or more contributor license agreements.  See the NOTICE file
    +       distributed with this work for additional information
    +       regarding copyright ownership.  The ASF licenses this file
    +       to you under the Apache License, Version 2.0 (the
    +       "License"); you may not use this file except in compliance
    +       with the License.  You may obtain a copy of the License at
    +
    +         http://www.apache.org/licenses/LICENSE-2.0
    +
    +       Unless required by applicable law or agreed to in writing,
    +       software distributed under the License is distributed on an
    +       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +       KIND, either express or implied.  See the License for the
    +       specific language governing permissions and limitations
    +       under the License.
    +*/
    +
    +/*jshint node: true*/
    +
    +var Q = require('q'),
    +    nopt  = require('nopt'),
    +    path  = require('path'),
    +    shell = require('shelljs'),
    +    build = require('./build'),
    +    spawn = require('./spawn'),
    +    check_reqs = require('./check_reqs');
    +
    +var cordovaPath = path.join(__dirname, '..');
    +var projectPath = path.join(__dirname, '..', '..');
    +
    +module.exports.run = function (argv) {
    +
    +    // parse args here
    +    // --debug and --release args not parsed here
    +    // but still valid since they can be passed down to build command 
    +    var args  = nopt({
    +        // "archs": String,     // TODO: add support for building different archs
    +        "list": Boolean,
    +        "nobuild": Boolean,
    +        "device": Boolean, "emulator": Boolean, "target": String
    +    }, {}, argv);
    +
    +    // Validate args
    +    if (args.device && args.emulator) {
    +        return Q.reject('Only one of "device"/"emulator" options should be specified');
    +    }
    +
    +    // validate target device for ios-sim
    +    // Valid values for "--target" (case sensitive):
    +    var validTargets = ["iPhone-4s", "iPhone-5", "iPhone-5s", "iPhone-6-Plus", "iPhone-6",
    +        "iPad-2", "iPad-Retina", "iPad-Air", "Resizable-iPhone", "Resizable-iPad"];
    +    if (args.target && validTargets.indexOf(args.target) < 0 ) {
    +        return Q.reject(args.target + " is not a valid target for emulator");
    +    }
    +
    +    // check for either ios-sim or ios-deploy is available
    +    // depending on arguments provided
    +    var checkTools = args.device ? check_reqs.check_ios_deploy() : check_reqs.check_ios_sim();
    +
    +    // support for CB-8168 `cordova/run --list`
    +    if (args.list) {
    +        if (args.device) return listDevices();
    +        if (args.emulator) return listEmulators();
    +        return listDevices().then(function () {
    +            return listEmulators();
    +        });
    +    }
    +
    +    return checkTools.then(function () {
    +        if (args.nobuild) {
    +            // --nobuild option is passed. Skipping build...
    +            return Q();
    +        }
    +        // if --nobuild isn't specified then build app first
    +        return build.run(argv);
    +    }).then(function () {
    +
    +        var xcodeProjFiles = shell.ls(projectPath).filter(function (name) {
    --- End diff --
    
    Seen this in a few spots now. Probably would be good to make a helper function for it. Maybe stick it in build.js?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org