Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jsoref <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-6-cordova-browser@git.apache.org>
In-Reply-To: <git-pr-6-cordova-browser@git.apache.org>
Subject: [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add
 suppo...
Content-Type: text/plain
Message-Id: <20150114185555.A123FA4264F@tyr.zones.apache.org>
Date: Wed, 14 Jan 2015 18:55:55 +0000 (UTC)

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r22959941
  
    --- Diff: node_modules/.bin/shjs ---
    @@ -1 +1,15 @@
    -../shelljs/bin/shjs
    --- End diff --
    
    @mmocny : checking them in is the only way things actually work, otherwise offline installs and various other things break.
    
    blackberry10 checks in its node_modules too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org