Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: mmocny <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-6-cordova-browser@git.apache.org>
In-Reply-To: <git-pr-6-cordova-browser@git.apache.org>
Subject: [GitHub] cordova-browser pull request: CB-8206: Browser platform: Add
 suppo...
Content-Type: text/plain
Message-Id: <20150114182449.4713DA424A4@tyr.zones.apache.org>
Date: Wed, 14 Jan 2015 18:24:49 +0000 (UTC)

Github user mmocny commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/6#discussion_r22957388
  
    --- Diff: node_modules/.bin/shjs ---
    @@ -1 +1,15 @@
    -../shelljs/bin/shjs
    --- End diff --
    
    Why are node_modules even checked in?  Shouldn't they just be added to .gitignore?  I double checked, and the only other cordova repo that checks these in is firefoxos, which I think is also an oversight.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org