cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpchase <...@git.apache.org>
Subject [GitHub] cordova-js pull request: CB-8210 Remove unused onDestroy channel
Date Fri, 09 Jan 2015 19:07:03 GMT
GitHub user jpchase opened a pull request:

    https://github.com/apache/cordova-js/pull/99

    CB-8210 Remove unused onDestroy channel

    - Channel was defined as internal event and fired by javascript eval()
    - Rather than change firing of event, simpler to remove as was not used
    
    Related to apache/cordova-android#146

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpchase/cordova-js CB8210-remove-ondestroy

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/99.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #99
    
----
commit ebf5d997cc6fddcbafb044198b396beb0e9408d4
Author: Jason Chase <jasonpchase@gmail.com>
Date:   2015-01-09T18:53:46Z

    CB-8210 Remove unused onDestroy channel
    - Channel was defined as internal event and fired by javascript eval()
    - Rather than change firing of event, simpler to remove as was not used

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message