cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggmichaelgo <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: Fixed returnLocationError...
Date Mon, 19 Jan 2015 16:12:42 GMT
GitHub user ggmichaelgo opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/35

    Fixed returnLocationError function's issues

    There were 2 issues with returnLocationError function.
    The function doesn't parse the NSNumber callback id to NSString.
    That issue results the JS error callback function not getting called.
    
    Also, the watchCallbackIds are not removed after error callback.
    So, on next returnLocationError call, it results errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ggmichaelgo/cordova-plugin-geolocation ggmichaelgo-patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 3e2c82d992e39e2ec9b6ab071ee19db2b3f85fed
Author: ggmichaelgo <ggmichaelgo@gmail.com>
Date:   2015-01-19T16:05:02Z

    remove watchCallbacks ids after error callback

commit 1c4c5836327ef0ef19e654ae1e3cd39a398421ef
Author: ggmichaelgo <ggmichaelgo@gmail.com>
Date:   2015-01-19T16:07:09Z

    convert NSNumber callback id to NSString

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message